Remove unused function - RabbitMQ #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmdrs
previously approved these changes
Apr 11, 2023
There was a problem hiding this comment.
LGTM 👍
To be fair, I'm not so sure that this in unused, is suppose to ensure the channel is clear after the reading a message, but I think the effect would be the same if there are some messages left, it would eventually fail the check if not publishing properly anyway.
Thank you for the contribution. Please make sure to add a description to the PR 🙂
lucasmdrs
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the empty "messages" function because it was breaking the Linter.