Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Rabbit checker and added tests #9

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Fixed Rabbit checker and added tests #9

merged 1 commit into from
Sep 25, 2017

Conversation

vgarvardt
Copy link
Contributor

No description provided.

@aleksandrzhiliaev
Copy link
Contributor

aleksandrzhiliaev commented Sep 22, 2017 •
edited by anmaf
Loading

:shipit:

Approved with PullApprove

rafaeljesus
rafaeljesus reviewed Sep 22, 2017
View reviewed changes
Makefile
checks:
@docker-compose up -d
@sleep 3
@echo "Running checks tests against container deps" && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😮 such a good test man

@rafaeljesus
Copy link
Contributor

rafaeljesus commented Sep 22, 2017 •
edited by anmaf
Loading

👍

Approved with PullApprove Approved with PullApprove

@stefvaessen
Copy link

stefvaessen commented Sep 25, 2017 •
edited by anmaf
Loading

+1

Approved with PullApprove Approved with PullApprove

@vgarvardt vgarvardt merged commit d22affb into master Sep 25, 2017
@vgarvardt vgarvardt deleted the hotfix/tests branch September 25, 2017 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaeljesus rafaeljesus rafaeljesus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vgarvardt @aleksandrzhiliaev @rafaeljesus @stefvaessen