Prevent Check to send result to closed channel #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioserra
approved these changes
Oct 21, 2022
grzn
reviewed
Oct 21, 2022
| resCh <- res | ||
| } | ||
| resCh <- c.Check(ctx) | ||
| defer close(resCh) |
There was a problem hiding this comment.
@lucasmdrs , the defer should be before the Check, no? if the Check does not end, this will never get closed?
There was a problem hiding this comment.
Hi @grzn
Changing the order of the defer would not change anything, endless checks will always result in leaky goroutines.
The changes done here will make open channels not be closed until those goroutines are finished.
It's still not the best solution, but ensures that there's no race condition between timeouts and checks
I'll work to improve this entire logic a bit, but that will be out of the scope for the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prevents a race condition between timeout and the Check execution result by delegating the closing command to the goroutine where the Check work done.
Since the work happened before checking the channel state the performance should not be impacted.
Closes #84