Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: allow to add a component description alongside system infos #75

Conversation

obouchet-unity
Copy link
Contributor

Description

This PR is about allowing someone to provide a brief description of the component (name and version) on which health check is performed so that it is easy to relate the status to the source component of the checks.

If the component is not provided then the status will print empty values for both name and version.

@obouchet-unity obouchet-unity changed the title feature: allow to add a component description attached system infos feature: allow to add a component description alongside system infos Jul 27, 2022
@vgarvardt
Copy link
Contributor

Thank you for your contribution.

Overall I'm fine to add this. Just a minor code suggestion.

@obouchet-unity
Copy link
Contributor Author

Thank you for your contribution.

Overall I'm fine to add this. Just a minor code suggestion.

Thank you for accepting this small contribution!
I might contribute more in the following weeks by maybe adding some checkers but so far it is working as expected and fits our needs. Thank you!

@vgarvardt vgarvardt merged commit 878bfef into hellofresh:master Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants