Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to go-redis client as gomodule removed version being used #44

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Switch to go-redis client as gomodule removed version being used #44

merged 2 commits into from
Sep 2, 2020

Conversation

vgarvardt
Copy link
Contributor

Fixes #43

@vgarvardt vgarvardt force-pushed the hotfix/go-redis-client branch 2 times, most recently from 3ba676b to 3a4e55d Compare September 2, 2020 09:44
@vgarvardt vgarvardt force-pushed the hotfix/go-redis-client branch from 3a4e55d to a5bd442 Compare September 2, 2020 09:48
@codecov
Copy link

codecov bot commented Sep 2, 2020 •
edited
Loading

Codecov Report

Merging #44 into master will increase coverage by 1.76%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   62.20%   63.96%   +1.76%     
==========================================
  Files           7        7              
  Lines         254      247       -7     
==========================================
  Hits          158      158              
+ Misses         61       56       -5     
+ Partials       35       33       -2
Impacted Files Coverage Δ
checks/redis/check.go 71.42% <75.00%> (+23.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db06f03...af2a56e. Read the comment docs.

@iammuho
Copy link

iammuho commented Sep 2, 2020 •
edited by hf-security
Loading

+1

Approved with Zappr Approved with Zappr

boekkooi-fresh
boekkooi-fresh reviewed Sep 2, 2020
View reviewed changes
@vgarvardt vgarvardt force-pushed the hotfix/go-redis-client branch from 321a59d to 550056b Compare September 2, 2020 09:58
@vgarvardt vgarvardt force-pushed the hotfix/go-redis-client branch from 550056b to af2a56e Compare September 2, 2020 10:00
@boekkooi-fresh
Copy link

boekkooi-fresh commented Sep 2, 2020 •
edited by hf-security
Loading

👍

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@fftorres
Copy link

fftorres commented Sep 2, 2020 •
edited by hf-security
Loading

+1

Approved with Zappr Approved with Zappr Approved with Zappr Approved with Zappr

@vgarvardt vgarvardt merged commit 96dfb46 into master Sep 2, 2020
@vgarvardt vgarvardt deleted the hotfix/go-redis-client branch September 2, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boekkooi-fresh boekkooi-fresh boekkooi-fresh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade redigo dependency
4 participants
@vgarvardt @iammuho @boekkooi-fresh @fftorres