Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for optionally opt-in system metrics #79

Closed
grzn opened this issue Oct 11, 2022 · 2 comments · Fixed by #82
Closed

add support for optionally opt-in system metrics #79

grzn opened this issue Oct 11, 2022 · 2 comments · Fixed by #82

Comments

@grzn
Copy link

grzn commented Oct 11, 2022

No description provided.

@lucasmdrs
Copy link
Contributor

Hi @grzn 👋

Could you please elaborate a bit more about this issue/request ?

@grzn
Copy link
Author

grzn commented Oct 12, 2022

Hi @lucasmdrs

Yes.
Today every call to the health handler internally makes a call to newSystemMetrics in order to return runtime info in the response.

What I'm asking for is to make this optional.
Kubelet doesn't parse the http response so it does not care about the number of gorouting and memory usage so we're spending CPU on this for no reason.

It'll be great if this was optional, e.g. WithSystemInfo()

eliflores pushed a commit that referenced this issue Oct 18, 2022
@lucasmdrs
Add support to optionally opt-in on System metrics
6492b1b 
Closes #79

Co-authored-by: Lucas Medeiros <[email protected]>
@eliflores eliflores mentioned this issue Oct 18, 2022
Merged
eliflores pushed a commit that referenced this issue Oct 19, 2022
@lucasmdrs
Add support to optionally opt-in on System metrics (#82)
a1fcc22 
Closes #79

Co-authored-by: Lucas Medeiros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support to optionally opt-in on System metrics hellofresh/health-go
2 participants
@grzn @lucasmdrs