Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _print.css #52

Merged
merged 1 commit into from
Apr 18, 2020
Merged

Update _print.css #52

merged 1 commit into from
Apr 18, 2020

Conversation

mattbrundage
Copy link
Contributor

Explicitly set print background to white -- "transparent" will not override the user's custom settings for background color. Confirmed in Firefox; see Options > Language & Appearance > Fonts and Colors > Colors > Background

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

Explicitly set print background to white -- "transparent" will not override the user's custom settings for background color. Confirmed in Firefox; see Options > Language & Appearance > Fonts and Colors > Colors > Background
@mattbrundage
Copy link
Contributor Author

Firefox example:

  • web page in print media simulation
  • web page using background: transparent !important in its print styles
  • user-customized background color

image

@roblarsen roblarsen merged commit a7f4f71 into h5bp:master Apr 18, 2020
@mattbrundage mattbrundage deleted the patch-1 branch April 20, 2020 12:45
@roblarsen roblarsen added this to the v2.1.0 milestone Apr 28, 2020
@coliff coliff mentioned this pull request Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants