Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode-graphql-syntax] Add support for GraphQL embedded in Hack files #3872

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dunnbobcat
Copy link
Contributor

@dunnbobcat dunnbobcat commented Mar 4, 2025

Summary:
This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README.

Test Plan:

  • yarn test -u from package root
  • yarn vsce:package and install resulting VSIX
  • Load test.hack in VS Code
  • Observe nice syntax highlighting for GraphQL

Screenshot 2025-03-04 at 10 07 57 AM

Summary:
This adds support for GraphQL strings within Hack files, bootstrapped from the
existing PHP version. I followed the steps outlined in the README.

Test Plan:
- `yarn test -u` from package root
- `yarn vsce:package` and install resulting VSIX
- Load `test.hack` in VS Code
- Observe nice syntax highlighting for GraphQL
Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: bf7c039

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vscode-graphql-syntax Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

linux-foundation-easycla bot commented Mar 4, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

dunnbobcat and others added 2 commits March 4, 2025 16:13
Summary:
This adds support for GraphQL strings within Hack files, bootstrapped from the
existing PHP version. I followed the steps outlined in the README.

Test Plan:
- `yarn test -u` from package root
- `yarn vsce:package` and install resulting VSIX
- Load `test.hack` in VS Code
- Observe nice syntax highlighting for GraphQL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant