Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add graphql-language-service-server as a dep #2267

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Conversation

elken
Copy link
Contributor

@elken elken commented Mar 31, 2022

Fixes #2264

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2022

🦋 Changeset detected

Latest commit: 5b0e6af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
graphql-language-service-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: elken / name: Ellis Kenyő (24c313a)

@acao
Copy link
Member

acao commented Mar 31, 2022

thank you @elken !

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #2267 (5b0e6af) into main (2d91916) will decrease coverage by 0.99%.
The diff coverage is 74.00%.

@@            Coverage Diff             @@
##             main    #2267      +/-   ##
==========================================
- Coverage   65.70%   64.71%   -1.00%     
==========================================
  Files          85       81       -4     
  Lines        5106     5314     +208     
  Branches     1631     1700      +69     
==========================================
+ Hits         3355     3439      +84     
- Misses       1747     1871     +124     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/utils/hintList.ts 95.65% <ø> (ø)
...ackages/codemirror-graphql/src/utils/info-addon.ts 1.02% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
... and 73 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9458e10...5b0e6af. Read the comment docs.

@acao acao merged commit fe44127 into graphql:main Mar 31, 2022
@github-actions github-actions bot mentioned this pull request Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't install graphql-language-service-cli globally without graphql-language-service-server
2 participants