-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: monaco getModeId
bug for monaco-editor@^0.30.0
#2118
Conversation
🦋 Changeset detectedLatest commit: 2868d1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest changes of this PR are available as canary in npm (based on the declared |
3894921
to
48c75fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #2118 +/- ##
==========================================
- Coverage 65.70% 64.78% -0.93%
==========================================
Files 85 77 -8
Lines 5106 5185 +79
Branches 1631 1654 +23
==========================================
+ Hits 3355 3359 +4
- Misses 1747 1822 +75
Partials 4 4
Continue to review full report at Codecov.
|
48c75fc
to
2868d1e
Compare
We fixed this already, but I think we reverted it because folks were having issues with older versions. This makes it work for all versions of
monaco-editor
, how about that?