Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monaco getModeId bug for monaco-editor@^0.30.0 #2118

Merged
merged 2 commits into from
Dec 13, 2021

Conversation

acao
Copy link
Member

@acao acao commented Dec 13, 2021

We fixed this already, but I think we reverted it because folks were having issues with older versions. This makes it work for all versions of monaco-editor, how about that?

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2021

🦋 Changeset detected

Latest commit: 2868d1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

The latest changes of this PR are available as canary in npm (based on the declared changesets):

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 13, 2021 18:37 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 13, 2021 18:40 Inactive
@acao acao force-pushed the fix/monaco-language-id-bug branch from 3894921 to 48c75fc Compare December 13, 2021 18:40
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #2118 (2868d1e) into main (2d91916) will decrease coverage by 0.92%.
The diff coverage is 77.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2118      +/-   ##
==========================================
- Coverage   65.70%   64.78%   -0.93%     
==========================================
  Files          85       77       -8     
  Lines        5106     5185      +79     
  Branches     1631     1654      +23     
==========================================
+ Hits         3355     3359       +4     
- Misses       1747     1822      +75     
  Partials        4        4              
Impacted Files Coverage Δ
packages/codemirror-graphql/src/hint.ts 94.73% <ø> (ø)
packages/codemirror-graphql/src/lint.ts 100.00% <ø> (ø)
packages/codemirror-graphql/src/results/mode.ts 47.05% <ø> (ø)
...kages/codemirror-graphql/src/utils/forEachState.ts 100.00% <ø> (ø)
...ckages/codemirror-graphql/src/utils/mode-indent.ts 0.00% <0.00%> (ø)
packages/codemirror-graphql/src/variables/hint.ts 89.70% <ø> (ø)
packages/codemirror-graphql/src/variables/mode.ts 79.48% <ø> (ø)
packages/graphiql/src/components/QueryEditor.tsx 63.96% <ø> (ø)
packages/graphiql/src/utility/fillLeafs.ts 5.33% <ø> (ø)
...kages/graphiql/src/utility/introspectionQueries.ts 100.00% <ø> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e2b5e...2868d1e. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021

@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 13, 2021 18:43 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 13, 2021 18:44 Inactive
@acao acao force-pushed the fix/monaco-language-id-bug branch from 48c75fc to 2868d1e Compare December 13, 2021 18:48
@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to monaco-graphql-webpack-preview December 13, 2021 18:51 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-webpack-preview December 13, 2021 18:51 Inactive
@github-actions github-actions bot temporarily deployed to graphiql-cdn-preview December 13, 2021 18:52 Inactive
@acao acao merged commit 0d1122f into main Dec 13, 2021
@acao acao deleted the fix/monaco-language-id-bug branch December 13, 2021 19:15
@github-actions github-actions bot mentioned this pull request Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant