Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set schema statically #1548

Closed
wants to merge 1 commit into from
Closed

Conversation

acao
Copy link
Member

@acao acao commented May 23, 2020

this allows users to set the language service schema using an SDL string or an introspection JSON result

also in this PR:

  • move and correct the monaco.d.ts (still no proper definitions, api intellisense)
  • make createData simpler
  • update docs, fix a typo
  • add npmignore lines for tsbuild output which adds a whole MB or more to our npm package

CC @Nishchit14

@acao acao force-pushed the feat/set-schema-static branch from 8813897 to 9c75664 Compare May 25, 2020 13:25
@Nishchit14
Copy link
Contributor

LGTM 🔥

@acao
Copy link
Member Author

acao commented May 25, 2020

@Nishchit14 it is not sadly, been churning on the triple slash directives for monaco since last weekend :(. still can't get the monaco API patterns working right

@acao
Copy link
Member Author

acao commented May 25, 2020

image

can't seem to get the module extensions working again

@Nishchit14
Copy link
Contributor

I see I like the spec by reading the README. But as I am a newbie for TS and Monaco I could not go into the implementation. But I am learning it and I wish soon I can help you. :)

@acao
Copy link
Member Author

acao commented Jun 11, 2020

this was accomplished in a better way in another upstream PR

@acao acao closed this Jun 11, 2020
@connorshea
Copy link
Contributor

@acao sorry, could you explain what you mean by another upstream PR? I'm interested in this functionality and I'm not sure what you mean :)

@harshithpabbati
Copy link
Contributor

@connorshea he means about this #1575 PR

@acao
Copy link
Member Author

acao commented Jun 18, 2020

@connorshea my bad., a clearer thing to say is that this has been released in the latest version of [email protected] 🎉 . note that there is a breaking change in the API, please read the docs

docs are in the subpackage readme. enjoy! let me know if there are issues please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants