Fix bad iovec length check #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grcevski
commented
Jun 27, 2024
| @@ -229,9 +229,8 @@ static __always_inline int read_msghdr_buf(struct msghdr *msg, u8* buf, int max_ | |||
| continue; | |||
| } | |||
|
|
|||
| u32 l = vec.iov_len; | |||
There was a problem hiding this comment.
This local was overwriting the real 'l' which we check for on line 238.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
- Coverage 80.56% 80.51% -0.06%
==========================================
Files 134 134
Lines 10591 10591
==========================================
- Hits 8533 8527 -6
- Misses 1557 1560 +3
- Partials 501 504 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
marctc
approved these changes
Jun 27, 2024
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
* Improve detection for http2 in reversed connections * Add more grpc validation and a test * Support broken-up iov segments * Fixed commented out tests * make verifer happy * Fix issue with missing data read * Fix issues for kernel 5.10 * Fix bpf logger helper, reduce grpc loop size * undo ok check * fix bad iovec len check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my last PR I noticed an error for which I can't seem to write a test. The length I was checking was overwritten and it works for our cases, but it should've been the max_length clamped to the IO_VEC_MAX_LEN.