Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instrumenter logging #75

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Apr 20, 2023

Not finding all components that we can instrument in an application is normal. For example, we may find symbols related to http.Serve, but no symbols for gRPC. At the same time, it would be good to show what components (features) we managed to instrument in an application.

  • This PR changes few Warn messages to Debug, related to not finding certain symbol offsets.
  • This PR also prints which features we instrumented in a given application.

For example, on start we'd print this for our integration tests server with INFO logging:

time=2023-04-20T10:46:36.076-04:00 level=INFO msg="creating instrumentation pipeline"
time=2023-04-20T10:46:36.270-04:00 level=INFO msg="instrumented features ['go runtime','http server','grpc server']"
time=2023-04-20T10:46:36.271-04:00 level=INFO msg="Starting main node"

If we try to instrument our pingserver test application, we'll only print a subset, e.g no 'grpc server':

time=2023-04-20T10:46:36.076-04:00 level=INFO msg="creating instrumentation pipeline"
time=2023-04-20T10:46:36.270-04:00 level=INFO msg="instrumented features ['go runtime','http server']"
time=2023-04-20T10:46:36.271-04:00 level=INFO msg="Starting main node"

@grcevski grcevski merged commit 0e47935 into grafana:main Apr 20, 2023
@grcevski grcevski deleted the improve_instrumenter_logging branch April 20, 2023 19:03
@grcevski
Copy link
Contributor Author

Thanks Mario!

mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants