Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct tutorial doc link in readme #227

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

vakalapa
Copy link
Contributor

@vakalapa vakalapa commented Aug 4, 2023

Tutorial doc link seems to be pointing to a non-existent file, correcting it and hope this file is the right one.

@CLAassistant
Copy link

CLAassistant commented Aug 4, 2023

CLA assistant check
All committers have signed the CLA.

@MattFrick
Copy link
Contributor

I think this used to link to what is now: docs/sources/standalone.md
I agree it needs to be fixed as it stands out for those perusing on github. I didn't quite understand why it needed to be changed, but here's where it was changed: 1889a36

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks good to me. @vakalapa can you please sign the CLA so we can merge this? Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

Merging #227 (ef6b67e) into main (b4841e4) will decrease coverage by 42.71%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #227       +/-   ##
===========================================
- Coverage   80.65%   37.95%   -42.71%     
===========================================
  Files          37       35        -2     
  Lines        3066     2951      -115     
===========================================
- Hits         2473     1120     -1353     
- Misses        442     1765     +1323     
+ Partials      151       66       -85     
Flag Coverage Δ
integration-test ?
unittests 37.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 30 files with indirect coverage changes

@grcevski grcevski merged commit 403da82 into grafana:main Aug 11, 2023
@grcevski
Copy link
Contributor

Thanks again for your contribution @vakalapa

@vakalapa vakalapa deleted the vakr/correcttutorilalink branch November 15, 2023 22:00
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
chore: correct tutorial doc link in readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants