Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing systemwide command reporting #219

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

mariomac
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #219 (4965be5) into main (64f4331) will increase coverage by 1.01%.
The diff coverage is 62.50%.

@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   80.17%   81.18%   +1.01%     
==========================================
  Files          35       35              
  Lines        2774     2780       +6     
==========================================
+ Hits         2224     2257      +33     
+ Misses        411      385      -26     
+ Partials      139      138       -1     
Flag Coverage Δ
integration-test 75.64% <62.50%> (+1.01%) ⬆️
unittests 40.33% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/internal/export/prom/prom.go 98.05% <57.14%> (-1.95%) ⬇️
pkg/beyla/beyla.go 84.48% <100.00%> (ø)

... and 3 files with indirect coverage changes

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice! Yeah in system wide we don't have a single executable, so we have to get it from the eBPF side.

@mariomac mariomac merged commit 070f2f6 into grafana:main Jul 28, 2023
@mariomac mariomac deleted the fix-systemwide branch July 28, 2023 14:05
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
fixing systemwide command reporting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants