Fix integration tests timeouts #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
===========================================
+ Coverage 40.35% 81.29% +40.93%
===========================================
Files 34 35 +1
Lines 2649 2705 +56
===========================================
+ Hits 1069 2199 +1130
+ Misses 1517 373 -1144
- Partials 63 133 +70
Flags with carried forward coverage won't be shown. Click here to find out more. |
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
* fix integration tests timeouts * prevent early notification of coverage * Fix timeout also in makefile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the
make integration-testsstep timeout to 60 minutes, to avoid premature killing.Also disables temporarily the kubernetes tests, as we don't need them at the moment.
Also tries to fix Codecov to avoid premature reporting of coverage data (e.g. report unit tests coverage before waiting for integration tests to finish)