Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework for Kubernetes integration tests #214

Merged
merged 7 commits into from
Jul 26, 2023
Merged

Conversation

mariomac
Copy link
Contributor

Some future tasks might require testing Beyla in kubernetes. For example, to test Kubernetes metadata decoration.

This only adds a smoke test that can be skipped in later PRs, if we verify that K8s tests work properly in GitHub.

This also introduces a breaking change for the PROMETHEUS_PORT variable, in advance to the work that has to be done in the issue #213

@codecov-commenter
Copy link

Codecov Report

Merging #214 (e9c7f35) into main (0b5271f) will decrease coverage by 40.94%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main     #214       +/-   ##
===========================================
- Coverage   81.29%   40.35%   -40.94%     
===========================================
  Files          35       34        -1     
  Lines        2705     2649       -56     
===========================================
- Hits         2199     1069     -1130     
- Misses        373     1517     +1144     
+ Partials      133       63       -70     
Flag Coverage Δ
integration-test ?
unittests 40.35% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/export/prom/prom.go 1.34% <ø> (-98.66%) ⬇️
pkg/pipe/config.go 56.41% <100.00%> (ø)

... and 26 files with indirect coverage changes

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@MattFrick MattFrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great test setup. I skipped the ~2360 files inside the vendor folder. Thanks.

@mariomac mariomac merged commit d42f279 into grafana:main Jul 26, 2023
@mariomac mariomac deleted the k8s-tests branch July 26, 2023 07:58
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
* k8s base test cluster (untested)

* Fixed k8s deployments

* barely working k8s test deployment

* working smoke test

* working version

* Release candidate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants