Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test that demonstrates the status bug #204

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

grcevski
Copy link
Contributor

In this testcase we have a Go middleware that has its own implementation of ResponseWriter, which in turn stores the statusCode in it's own field.

I didn't add an integration test yet because it will fail.

Relates to #202

@grcevski grcevski added the test Issues related to testing label Jul 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #204 (474d63d) into main (8aac953) will decrease coverage by 40.80%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #204       +/-   ##
===========================================
- Coverage   81.23%   40.43%   -40.80%     
===========================================
  Files          35       34        -1     
  Lines        2697     2641       -56     
===========================================
- Hits         2191     1068     -1123     
- Misses        373     1510     +1137     
+ Partials      133       63       -70     
Flag Coverage Δ
integration-test ?
unittests 40.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

@grcevski grcevski mentioned this pull request Jul 20, 2023
2 tasks
@grcevski grcevski merged commit b9fcac6 into grafana:main Jul 21, 2023
@grcevski
Copy link
Contributor Author

Thanks Mario!

@grcevski grcevski deleted the go_middleware_status_example branch July 21, 2023 13:07
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
…mple

Add test that demonstrates the status bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants