-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add local documentation webserver #169
Conversation
…ll other projects Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
Signed-off-by: Jack Baldry <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
There's seems to be a validation failure in the pipeline that needs to be looked at.
@@ -6,7 +6,7 @@ eBPF-based autoinstrumentation of HTTP/HTTPS/GRPC Go services, as well as HTTP/H | |||
written in other languages (intercepting Kernel-level socket operations as well as | |||
OpenSSL invocations). | |||
|
|||
[Documentation](./docs). | |||
[Documentation](https://grafana.com/docs/TODO). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. We started the conversation on naming few weeks ago, we'll come up with a name and re-brand everything by end of the month.
Indeed there is, this is |
OK, great, I can do that work. I'll make a PR with the required changes on top of this branch, so we can merge that before we merge this PR fully. Thanks! |
Great plan! |
I made a PR with these changes: #170 |
Hm, my PR still fails with this error:
|
Thanks! I'll take a look and see what's going wrong between |
Signed-off-by: Jack Baldry <[email protected]>
Add description for doc pages.
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
===========================================
- Coverage 81.46% 39.08% -42.39%
===========================================
Files 35 34 -1
Lines 2466 2410 -56
===========================================
- Hits 2009 942 -1067
- Misses 337 1410 +1073
+ Partials 120 58 -62
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: Jack Baldry <[email protected]>
I'm going to merge this so that any future docs work doesn't cause conflicts. Hit me up if you need any follow up PRs to fix if you spot anything that's not right. |
…ishing Add local documentation webserver
This PR reorganizes the documentation into the directory structure consistent with all other projects documented at https://grafana.com/docs/.
It adds a Makefile in the
docs/
directory that has targets for running a local webserver to view the generated Hugo site at http://localhost:3002/docs/ebpf-autoinstrument/latest/. A workflow is added to automatically update the Makefile and supporting files from the centralized source in Writers' Toolkit. I've added myself as a CODEOWNER and will ensure that I promptly validate, review, and merge those update PRs.It also adds a
doc-validator
workflow that lints technical documentation. The tool is still a work in progress but it provides useful guidance for correct use of the Hugorelref
shortcode, checking link anchors exist in destination pages, as well as other linting checks. It provides comments to PRs automatically and for trivial fixes, it even provides suggestions. Please report any bugs to me in #docs-squad on Slack or as a GitHub issue in https://github.com/grafana/technical-documentation/issues.You can run
doc-validator
locally withmake doc-validator
. It has structured JSON output that can be made more human readable using something like:make -s doc-validator | jq -r '"ERROR: \(.location.path):\(.location.range.start.line // 1):\(.location.range.start.column // 1): \(.message). Suggestion: \(.suggestions[0].text // "")"
TO DO (team):
Do we want to publish versioned documentation at this point in time? I don't see any tags or long lived version branches so I'm expecting that we are happy to just publish whatever is in main.