Fix issue with nested SSL requests #1627
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently we didn't notice that the switch to use uprobes for uretprobes doesn't work for SSL_do_handshake. The handshake can jump instead of return and our return probe doesn't fire, causing a confusion on which connection the SSL belongs to and causing us to miss events.
I reproduced this with Python SSL -> Postgresql SSL.
I want to see if we can pass tests without this uprobe (it shouldn't be needed) but maybe we need another approach.