Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nested SSL requests #1627

Merged
merged 5 commits into from
Feb 11, 2025
Merged

Fix issue with nested SSL requests #1627

merged 5 commits into from
Feb 11, 2025

Conversation

grcevski
Copy link
Contributor

@grcevski grcevski commented Feb 8, 2025

Apparently we didn't notice that the switch to use uprobes for uretprobes doesn't work for SSL_do_handshake. The handshake can jump instead of return and our return probe doesn't fire, causing a confusion on which connection the SSL belongs to and causing us to miss events.

I reproduced this with Python SSL -> Postgresql SSL.

I want to see if we can pass tests without this uprobe (it shouldn't be needed) but maybe we need another approach.

@grcevski grcevski requested a review from a team as a code owner February 8, 2025 20:58
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.13%. Comparing base (dd004f0) to head (9e050da).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1627      +/-   ##
==========================================
- Coverage   71.18%   71.13%   -0.06%     
==========================================
  Files         197      197              
  Lines       19881    19881              
==========================================
- Hits        14153    14142      -11     
- Misses       5044     5060      +16     
+ Partials      684      679       -5     
Flag Coverage Δ
integration-test 52.84% <ø> (+0.27%) ⬆️
k8s-integration-test 53.84% <ø> (-0.10%) ⬇️
oats-test 34.64% <ø> (+0.18%) ⬆️
unittests 47.06% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grcevski grcevski changed the title WIP: Fix issue with nested SSL requests Fix issue with nested SSL requests Feb 10, 2025
@grcevski grcevski merged commit 9879153 into grafana:main Feb 11, 2025
15 checks passed
@grcevski grcevski deleted the tcp_sql branch February 11, 2025 01:16
grcevski added a commit to grcevski/ebpf-autoinstrument that referenced this pull request Feb 12, 2025
grcevski added a commit that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants