Exposing internal metrics #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #145 +/- ##
===========================================
+ Coverage 39.56% 76.30% +36.73%
===========================================
Files 32 34 +2
Lines 2219 2304 +85
===========================================
+ Hits 878 1758 +880
+ Misses 1284 406 -878
- Partials 57 140 +83
Flags with carried forward coverage won't be shown. Click here to find out more.
|
grcevski
approved these changes
Jun 17, 2023
|
I'm not sure about the test failures, seems like some sort of setup issue? |
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
* Started infrastructure for internal metrics * Prometheus internal metrics export. Not yet tested nor documented * integration tests * Fix Prometheus instrumentation when Prometheus traces exporter is not set * flaky test * fix flaky test again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It exposes, as Prometheus metrics, a single metric: the number of flushed traces from the different eBPF traces.
It required moving the Prometheus server to another element (the connection.PrometheusManager), which will expose prometheus metrics from different places, using the same port and path, or different ones, depending on the preferences/configuration from the users.
It is still missing: