Don't fail if only PROMETHEUS_PORT is set #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 78.87% 78.88% +0.01%
==========================================
Files 30 31 +1
Lines 2111 2112 +1
==========================================
+ Hits 1665 1666 +1
Misses 331 331
Partials 115 115
Flags with carried forward coverage won't be shown. Click here to find out more.
|
grcevski
approved these changes
Jun 7, 2023
|
|
||
| func findNamespace(_ int32) (uint32, error) { | ||
| // convenience method to allow unit tests compiling in Darwin | ||
| return 1, nil |
There was a problem hiding this comment.
Should we return 0, so that we don't set anything? 1 will be the init process, so we might be instrumenting a wrong process id?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus export is a valid export node itself, so the instrumenter should init even if no other exports are provided.
It also fixes a unit test not compiling in Darwin.