Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linter and unit tests in Darwin #124

Merged
merged 2 commits into from
May 26, 2023
Merged

Conversation

mariomac
Copy link
Contributor

Moves some symbols that are only available on Linux to its own _linux.go file.

@mariomac mariomac requested a review from grcevski as a code owner May 26, 2023 14:04
@codecov-commenter
Copy link

Codecov Report

Merging #124 (b94b8e2) into main (1001faa) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   71.78%   71.78%           
=======================================
  Files          27       28    +1     
  Lines        1857     1857           
=======================================
  Hits         1333     1333           
  Misses        420      420           
  Partials      104      104           
Flag Coverage Δ
integration-test 59.79% <0.00%> (ø)
unittests 40.03% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ebpf/instrumenter.go 43.47% <ø> (+9.77%) ⬆️
pkg/ebpf/instrumenter_linux.go 0.00% <0.00%> (ø)

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@mariomac mariomac merged commit af9cb47 into grafana:main May 26, 2023
@mariomac mariomac deleted the fix-mac branch May 26, 2023 15:52
mattdurham pushed a commit to mattdurham/beyla that referenced this pull request Jan 22, 2025
* Fix linter and unit tests in Darwin

* move common.Filter.Close too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants