-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two ports to service, daemonset and servicemonitor conditionally #1168
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
==========================================
+ Coverage 81.13% 81.23% +0.10%
==========================================
Files 136 136
Lines 11431 11447 +16
==========================================
+ Hits 9274 9299 +25
+ Misses 1633 1623 -10
- Partials 524 525 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I have added one more change that will only use the 'metrics' port for Service, Daemonset and ServiceMonitor if both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…rafana#1168) * Add two ports to service, daemonset and servicemonitor conditionally * Update Helm docs * Only use 1 port if ports in config are equal * Change default internal metrics path to /metrics * Remove .metrics. from Prometheus metrics values
Closes #1165
Instead of having a Service with single port and having to choose whether that is the Prometheus metrics or the internal metrics port, this allows for having a single Service with either one or two ports. By default, for ease of use, these are using the values from the Beyla config
.Values.config.data.prometheus_export.port
and.Values.config.data.internal_metrics.prometheus.port
but can be overridden.In order to accommodate this change, in
values.yaml
the structure of the Service and ServiceMonitor sections were changed to have dedicated subproperties for the two ports.The most minimal and easy way to use this change is to enable the Service (and possibly the ServiceMonitor) through the values and then set up the Beyla configuration, for example:
This will result in both the Service and ServiceMonitor being created and using the ports/paths specified in the Beyla config.