-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for gRPC client spans #104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariomac
approved these changes
May 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 73.70% 73.99% +0.29%
==========================================
Files 20 20
Lines 1464 1496 +32
==========================================
+ Hits 1079 1107 +28
- Misses 292 293 +1
- Partials 93 96 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Thanks Mario! |
mattdurham
pushed a commit
to mattdurham/beyla
that referenced
this pull request
Jan 22, 2025
Support for gRPC client spans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for gRPC client spans, much like we support HTTP client spans. We use the same logic to nest the gRPC spans within server gRPC spans or server HTTP spans.
Outstanding work:
Closes #9