Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traces tests fail with keepalive off #154

Closed
grcevski opened this issue Jun 26, 2023 · 0 comments
Closed

Traces tests fail with keepalive off #154

grcevski opened this issue Jun 26, 2023 · 0 comments
Assignees
@MattFrick

Comments

@grcevski
Copy link
Contributor

Making our HTTP client for integration tests run without keepalive, which is default for Go, it causes failure in few of the Traces tests.

To make this happen I ran the test suite with the following addition to the Transport configuration for the HTTP client:

DisableKeepAlives: true,
@grcevski grcevski added the bug label Jun 26, 2023
MattFrick added a commit to MattFrick/beyla that referenced this issue Jul 25, 2023
@MattFrick
Add integration test case with DisableKeepAlives enabled grafana#154
923b5a1 
Add simple trace/metric integration tests with DisableKeepAlives set to true.
In arguments to "go test", add the verbose flag and remove "/..." from module
path so that it prints out each test as it's running them.
MattFrick added a commit to MattFrick/beyla that referenced this issue Jul 25, 2023
@MattFrick
Add integration test case with DisableKeepAlives enabled grafana#154
6042c83 
Fix time comparison in test code that caused failure in issue grafana#154.
Add simple trace/metric integration tests with DisableKeepAlives set to true.
In arguments to "go test", add the verbose flag and remove "/..." from module
path so that it prints out each test as it's running them.
@MattFrick MattFrick mentioned this issue Jul 25, 2023
Merged
MattFrick added a commit that referenced this issue Jul 25, 2023
@MattFrick
Add integration test case with DisableKeepAlives enabled #154
0b5271f 
Fix time comparison in test code that caused failure in issue #154.
Add simple trace/metric integration tests with DisableKeepAlives set to true.
In arguments to "go test", add the verbose flag and remove "/..." from module
path so that it prints out each test as it's running them.
mattdurham pushed a commit to mattdurham/beyla that referenced this issue Jan 22, 2025
@MattFrick
Add integration test case with DisableKeepAlives enabled grafana#154
225c34a 
Fix time comparison in test code that caused failure in issue grafana#154.
Add simple trace/metric integration tests with DisableKeepAlives set to true.
In arguments to "go test", add the verbose flag and remove "/..." from module
path so that it prints out each test as it's running them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MattFrick MattFrick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grcevski @MattFrick