Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add json tags to Claims #130

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Chore: Add json tags to Claims #130

merged 5 commits into from
Jan 21, 2025

Conversation

mgyongyosi
Copy link
Contributor

@mgyongyosi mgyongyosi commented Jan 14, 2025

Related PR: grafana/grafana#98926

@mgyongyosi mgyongyosi requested review from gamab and kalleep January 16, 2025 13:20
@mgyongyosi mgyongyosi marked this pull request as ready for review January 16, 2025 13:21
@mgyongyosi mgyongyosi requested a review from a team as a code owner January 16, 2025 13:21
@mgyongyosi mgyongyosi requested review from colin-stuart and removed request for a team January 16, 2025 13:21
Copy link
Contributor

@kalleep kalleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it now work to have inline tags for jwt.Claims and Rest?

@mgyongyosi
Copy link
Contributor Author

Would it now work to have inline tags for jwt.Claims and Rest?

I tried, but inline does not supported by the encoding/json package. :/ golang/go#6213

@mgyongyosi mgyongyosi requested a review from kalleep January 16, 2025 13:47
@kalleep
Copy link
Contributor

kalleep commented Jan 16, 2025

Oh, I wonder why I though it was supported 🤔

@kalleep
Copy link
Contributor

kalleep commented Jan 16, 2025

Should we also implement UnmarshalJSON?

@mgyongyosi mgyongyosi merged commit ec72a17 into main Jan 21, 2025
4 checks passed
@mgyongyosi mgyongyosi deleted the in-proc-changes branch January 21, 2025 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants