feat(pyroscope.write): Add labels validation #2918
Open
+241
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcsanmi
force-pushed
the
marcsanmi/add-labels-validation
branch
from
b976738 to
00c5c64
Compare
marcsanmi
force-pushed
the
marcsanmi/add-labels-validation
branch
from
00c5c64 to
874d4db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds validation for labels in the
pyroscope.writecomponent to ensure compatibility with Pyroscope's validation requirements. The validation:Which issue(s) this PR fixes
https://github.com/grafana/pyroscope-squad/issues/357
Notes to the Reviewer
service_namelabel existence. As talked, as far as using thereceive_http, this should come for free with ourensureServiceNamefunction and also validated at pyroscope side.PR Checklist