try/catch createShadowRoot in contentscripts #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a bad bug given the importance of this portion of code. Do you have a reproducible scenario where this happens with default settings? |
gorhill
added a commit
that referenced
this pull request
Aug 3, 2015
try/catch createShadowRoot in contentscripts
|
Thanks for the patch. |
|
For completeness, I first noticed this happening on https://www.reddit.com when
|
Ok, I could not see any lingering bad effects from the unhandled exception. Still, I consider this bug is serious enough to warrant a new release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the contentscripts throw an error when trying to call createShadowRoot on certain elements (iframes etc).