Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPS if possible when downloading filter lists. #2591

Merged
merged 1 commit into from
May 8, 2017
Merged

Use HTTPS if possible when downloading filter lists. #2591

merged 1 commit into from
May 8, 2017

Conversation

bershan2
Copy link
Contributor

@bershan2 bershan2 commented May 7, 2017

I tested changes in uBlock/assets/assets.json by loading the modified extension into Chrome and downloading all lists (after purging cache).

@gorhill
Copy link
Owner

gorhill commented May 7, 2017

Thanks.

I would like that you drop the changes for filter-lists.json, it's obsolete and I don't want it to be "revived" in the commit history.

@bershan2
Copy link
Contributor Author

bershan2 commented May 8, 2017

What is the point of keeping filter-lists.json at all? As far as I see, all the relevant content is already in assets.json, so do you keep filter-lists.json for backward compatibility? I saw #2314, but it does not outline a "to do" list. Or are you merely waiting for 1.11 to be widespread to drop support for old asset management?

@bershan2 bershan2 changed the title Use HTTPS when downloading filter lists in uBlock/filter-lists.json and uBlock/assets.json. Use HTTPS if possible when downloading filter lists. May 8, 2017
@gorhill gorhill merged commit 583ca9c into gorhill:master May 8, 2017
@gorhill
Copy link
Owner

gorhill commented May 8, 2017

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants