Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test wider range of float values #7971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Test wider range of float values #7971

wants to merge 1 commit into from
+252 −63

Conversation

copybara-service[bot]
Copy link
Contributor

Test wider range of float values

This requires a few fixes:

  • Cleaning up tolerances of tests
  • Fix infinity -> int conversion crashes
  • The RVV vrnd ukernels work by converting to int and back. This loses the "special" float values (inf, NaN). This change tries to at least preserve inf, matching NaN is a little trickier and also not quite as bad to lose (but we should find a way to do so).

@copybara-service copybara-service bot force-pushed the test_734782315 branch 3 times, most recently from e82e02f to 0375ac7 Compare March 8, 2025 06:21
@dsharletg @xnnpack-bot
Test wider range of float values
42d855c 
This requires a few fixes:
- Cleaning up tolerances of tests
- Fix infinity -> int conversion crashes
- The RVV vrnd ukernels work by converting to int and back. This loses the "special" float values (inf, NaN). This change tries to at least preserve inf, matching NaN is a little trickier and also not quite as bad to lose (but we should find a way to do so).

PiperOrigin-RevId: 734782315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsharletg