Skip to content
This repository was archived by the owner on Jun 27, 2023. It is now read-only.

mockgen: package _test prepend package name #248

Merged
merged 1 commit into from
Dec 21, 2018
Merged

mockgen: package _test prepend package name #248

merged 1 commit into from
Dec 21, 2018

Conversation

poy
Copy link
Collaborator

@poy poy commented Dec 6, 2018

fixes #247

@poy poy requested a review from balshetzer December 6, 2018 05:25
balshetzer
balshetzer reviewed Dec 18, 2018
View reviewed changes
@poy
Copy link
Collaborator Author

poy commented Dec 19, 2018

@balshetzer PTAL

balshetzer
balshetzer approved these changes Dec 20, 2018
View reviewed changes
Copy link
Collaborator

@balshetzer balshetzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks!

@poy
Copy link
Collaborator Author

poy commented Dec 21, 2018

Thanks! I'll squash and merge.

@poy poy merged commit c2e99c4 into golang:master Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balshetzer balshetzer balshetzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mockgen: does not handle types if mocks are in test package
2 participants
@poy @balshetzer