remove unnecessary for loop in token signing string for readability #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add testcase - add benchmark - improve performance slightly
oxisto
reviewed
Jul 31, 2021
oxisto
reviewed
Jul 31, 2021
lggomez
requested changes
Aug 22, 2021
There was a problem hiding this comment.
Looks good, needs an update from main and the requested change to make the benchmark to be more precise and report the allocations, otherwise I think we're fine (also see https://github.com/golang-jwt/jwt/pull/34/files#r680371882)
lggomez
reviewed
Jan 16, 2022
lggomez
approved these changes
Jan 16, 2022
mfridman
approved these changes
Feb 3, 2022
I was still cautions to touch functions that are the very core of this library, but it looks sound, doesn't add more allocations and is marginally faster, so I think you can merge it. |
oxisto
approved these changes
Feb 3, 2022
oxisto
pushed a commit
to moneszarrugh/jwt
that referenced
this pull request
Feb 21, 2023
…olang-jwt#34) * remove unnecessary for loop in token signing string for readability - add testcase - add benchmark - improve performance slightly * Fix benchtests on token_test.go * Update token_test.go to v4 Co-authored-by: hyeonjae <[email protected]> Co-authored-by: Luis Gabriel Gomez <[email protected]>
oxisto
pushed a commit
to twocs/jwt
that referenced
this pull request
Mar 29, 2023
…olang-jwt#34) * remove unnecessary for loop in token signing string for readability - add testcase - add benchmark - improve performance slightly * Fix benchtests on token_test.go * Update token_test.go to v4 Co-authored-by: hyeonjae <[email protected]> Co-authored-by: Luis Gabriel Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove unnecessary for-loop in token signing string for readability
and ...