Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update comments in template file of installation configurations #20929

Merged

Conversation

4everming
Copy link
Contributor

Update comments in template file of installation configurations.
Current descriptions make users a little bit confused about the 'root user'.

Copy link
Contributor

@reasonerjt reasonerjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.70%. Comparing base (c8c11b4) to head (81237b9).
Report is 280 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20929       +/-   ##
===========================================
+ Coverage   45.36%   66.70%   +21.33%     
===========================================
  Files         244     1047      +803     
  Lines       13333   114302   +100969     
  Branches     2719     2850      +131     
===========================================
+ Hits         6049    76244    +70195     
- Misses       6983    34163    +27180     
- Partials      301     3895     +3594     
Flag Coverage Δ
unittests 66.70% <ø> (+21.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

@chlins chlins added the release-note/ignore-for-release Do not include PR or Issue for release notes label Sep 25, 2024
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chlins chlins force-pushed the fix/update-comments-in-harbor.yam.tmpl branch from 7489945 to 81237b9 Compare September 25, 2024 03:31
@chlins chlins enabled auto-merge (squash) September 25, 2024 03:31
@chlins chlins merged commit 22eebd2 into goharbor:main Sep 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants