fix(no-raw-keys): do not report constants from other packages

[Jacobbrewer1]

Closes #66

This pull request includes changes to improve the handling of raw keys in the sloglint package. The most important changes include enhancing the key checking logic, adding new constant definitions, and modifying test cases to use the new constants.

Improvements to key checking logic:

• sloglint.go: Enhanced the logic in the visit function to handle package selectors and ensure that keys are constants defined within any package.

Additions to constant definitions:

• testdata/src/no_raw_keys/keys/consts.go: Added a new file to define package-level constants.

Updates to test cases:

• testdata/src/no_raw_keys/no_raw_keys.go: Modified imports to include the new constants and updated test cases to use these constants. [1] [2]

Testing

The new test case does not trigger the error

[Jacobbrewer1]

@tmzane I see the problem with the checks, GitHub is looking for a location that doesn't exist on the runner.

/home/runner/work/sloglint/sloglint/testdata/src/go-simpler.org/sloglint/testdata/src/no_raw_keys/keys (from $GOPATH)

Just taking a look at a solution now

[Jacobbrewer1]

@tmzane Here is the potential resolution https://stackoverflow.com/questions/64448560/golang-package-is-not-in-goroot-usr-local-go-src-packagename

[Jacobbrewer1]

@tmzane as this would be a CICD change most likely, I will remove the test case for now.

[tmzane]

I might have an idea how to fix it, let me check.

[tmzane]

Looks like the tests are passing now, good.

May I ask why you updated the check to use pass.TypesInfo.ObjectOf? It seems more complex now.

[tmzane]

Nevermind, I see now that *ast.Ident.Obj is deprecated and won't work for constants in other packages.

[tmzane]

@Jacobbrewer1 Thanks!