-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support With
and LogAttrs
functions
#41
Conversation
With
funcWith
and LogAttrs
funcs
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
- Coverage 84.06% 83.80% -0.26%
==========================================
Files 2 2
Lines 251 315 +64
==========================================
+ Hits 211 264 +53
- Misses 33 42 +9
- Partials 7 9 +2 ☔ View full report in Codecov by Sentry. |
This PR enforces the lint rules to `With` functions that are enforced to arguments in other logger funcs. Signed-off-by: Tiago Silva <[email protected]>
With
and LogAttrs
funcsWith
and LogAttrs
functions
Thanks! |
@tmzane can you please cut a new release so we can integrate it with our CI? |
Yep, just wanted to refactor some internals first. Almost done. |
This PR enforces the lint rules to
With
andLogAttrs
functions that are enforced to arguments in other logger funcs.Fixes #38