Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop the remaining cached gems from the project #45

Merged
merged 2 commits into from
Apr 27, 2017

Conversation

Empact
Copy link
Contributor

@Empact Empact commented Apr 27, 2017

vendor/gems was added to gitignore here: e265ac1

Don't see a reason to include dependencies, particularly dev dependencies in the gem to be installed everywhere it's used.

@gjtorikian
Copy link
Owner

Normally I don't include these either (or .bundle/config), but @kivikakk added them and I'm not sure why, so I defer to her on whether to include them or not.

So these settings can be configured locally as each developer prefers.
@Empact
Copy link
Contributor Author

Empact commented Apr 27, 2017

Cool I removed the bundle config as well - seems if one can go the other can.

@kivikakk
Copy link
Collaborator

Completely 👍 on dropping these. I don't quite recall why I added them.

@kivikakk kivikakk merged commit d60bfd7 into gjtorikian:master Apr 27, 2017
@gjtorikian
Copy link
Owner

Yaaay

@Empact Empact deleted the vendor-cache branch April 27, 2017 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants