Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

option ':default' does not exist for CommonMarker::Config::Render #37

Closed
raphink opened this issue Mar 20, 2017 · 4 comments
Closed

option ':default' does not exist for CommonMarker::Config::Render #37

raphink opened this issue Mar 20, 2017 · 4 comments

Comments

@raphink
Copy link

raphink commented Mar 20, 2017

Using 0.14.8 according to doc:

irb(main):001:0> require 'commonmarker'
=> true
irb(main):002:0> CommonMarker.render_html('Hi *there*', :default)
TypeError: option ':default' does not exist for CommonMarker::Config::Render
	from /var/lib/gems/2.3.0/gems/commonmarker-0.14.8/lib/commonmarker/config.rb:39:in `check_option'
	from /var/lib/gems/2.3.0/gems/commonmarker-0.14.8/lib/commonmarker/config.rb:26:in `process_options'
	from /var/lib/gems/2.3.0/gems/commonmarker-0.14.8/lib/commonmarker.rb:23:in `render_html'
	from (irb):2
	from /usr/bin/irb:11:in `<main>'
raphink referenced this issue in binford2k/showoff Mar 20, 2017
@binford2k
Adding commonmarker bloated the image enormously.
c70bed3 
Turns out that the gem included many MB of "test" files. While I was at
it, I trimmed out the rubygem cache too. This should be slightly smaller
than before.
@raphink
Copy link
Author

raphink commented Mar 20, 2017

Ah, I see d758e2c

It's not in the online doc though...

@gjtorikian
Copy link
Owner

Yes, sorry, the dependency that handled these options broke semantic versioning and made it so that all symbol names must be upper cases.

I made the change in the README but I'll regenerate the API docs too. Thanks!

@raphink
Copy link
Author

raphink commented Mar 20, 2017

@gjtorikian is there a way to make this backward-compatible? Such a change breaks the API completely from one version to the next

binford2k added a commit to binford2k/showoff that referenced this issue Mar 20, 2017
@binford2k
Pin to a working version of commonmarker
8130bd3 
Is this a good idea?

See gjtorikian/commonmarker#37
@binford2k binford2k mentioned this issue Mar 20, 2017
Merged
@gjtorikian
Copy link
Owner

I'm at the mercy of https://github.com/dblock/ruby-enum on that.

@rewritten rewritten mentioned this issue Jul 19, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gjtorikian @raphink