Don't force users to call free, if possible
#2
Comments
Merged
gjtorikian
added a commit
that referenced
this issue
Feb 26, 2023
Commonmarker currently has three different test suites related to the gem build: 1. The compilation output is tested 2. The gem can be installed on another platform 3. A generic version of the gem can be installed on a platform with sufficient Ruby/Rust tooling Of these, only the first is the most relevant. #2 suggests an error in the build pipeline, and #3 opens the door to supporting platforms that are uncommon. In order to minimize support work on my end, I'm going to nix the last two tests; as well, I can abstract the first test into a GitHub Action for other oxidizers to use.
gjtorikian
added a commit
that referenced
this issue
Feb 26, 2023
Commonmarker currently has three different test suites related to the gem build: 1. The compilation output is tested 2. The gem can be installed on another platform 3. A generic version of the gem can be installed on a platform with sufficient Ruby/Rust tooling Of these, only the first is the most relevant. #2 suggests an error in the build pipeline, and #3 opens the door to supporting platforms that are uncommon. In order to minimize support work on my end, I'm going to nix the last two tests; as well, I can abstract the first test into a GitHub Action for other oxidizers to use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: