fix: taxonomies missing lang in sitemap #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bemyak
commented
Dec 13, 2023
| assert!(file_contains!(public, "sitemap.xml", "https://example.com/tags/")); | ||
| assert!(file_contains!(public, "sitemap.xml", "https://example.com/tags/hello/")); | ||
| assert!(file_contains!(public, "sitemap.xml", "https://example.com/fr/tags/")); | ||
| assert!(file_contains!(public, "sitemap.xml", "https://example.com/fr/tags/bonjour/")); |
There was a problem hiding this comment.
The current version puts https://example.com/tags/bonjour/ here (notice missing fr), which results in lots of 404s in the crawlers.
Keats
reviewed
Dec 13, 2023
| name, | ||
| item.slug, | ||
| "{}{}/{}", | ||
| item.path, |
There was a problem hiding this comment.
are we ensuring it ends with a trailing slash upstream already?
There was a problem hiding this comment.
Yes, config.make_permalink ensures it.
I've now added the slash nevertheless just for the consistency.
bemyak
force-pushed
the
sitemaps-missing-tax-lang
branch
from
ec10a5f to
478c53b
Compare
Keats
approved these changes
Dec 13, 2023
|
Thanks! |
Keats
pushed a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
sitemap.xmlhaving incorrect i18n taxonomy URLs.Sanity check:
Code changes
nextbranch?