Allow external links to start with "www.*" #2100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pqcfox
changed the title
Keats
pushed a commit
that referenced
this pull request
Feb 16, 2023
|
I'm really confused what this PR is supposed to do -- a link starting with |
|
That's true, it should probably be reverted. |
Keats
added a commit
that referenced
this pull request
Mar 8, 2023
Keats
added a commit
that referenced
this pull request
Mar 19, 2023
theowenyoung
added a commit
to theowenyoung/zola
that referenced
this pull request
Mar 19, 2023
* 'master' of https://github.com/getzola/zola: Set release date Update changelog and disable clippy in CI for a bit Implement Default for LanguageOptions (getzola#2145) Fix cachebusting not working with binary files Fix tests Update changelog Use page.summary if available (getzola#2141) Update deps Remove dummy test Fix tests Update changelog Revert "Allow external links to start with "www.*" (getzola#2100)" Fix index errors (getzola#2129) Fix a page missing from e2e test Next verison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sanity check:
Code changes
Are you doing the PR on the
nextbranch?Have you created/updated the relevant documentation page(s)?
Description
This PR addresses #1967 by changing
is_external_linkto consider links with URLs starting with"www."as external links.