Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crash in build.rs when installing from source on linux #1760

Merged
merged 1 commit into from
Feb 11, 2022
Merged

fix crash in build.rs when installing from source on linux #1760

merged 1 commit into from
Feb 11, 2022

Conversation

savente93
Copy link
Contributor

The current build.rs fails to compile "widows resources" when installing from source on Linux, so I added a !cfg(windows) to fix that. That's all.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

Copy link
Collaborator

@Keats Keats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you can wrap L32 in the if cfg(windows) instead?

@savente93 savente93 requested a review from Keats February 11, 2022 11:11
@Keats
Copy link
Collaborator

Keats commented Feb 11, 2022

Thanks!

@Keats Keats merged commit 36726be into getzola:next Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants