Fix get_url resolving asset path to invalid url on Windows #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keats
requested changes
Oct 4, 2021
| @@ -456,6 +463,28 @@ title = "A title" | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| #[cfg(target_os = "windows")] | |||
There was a problem hiding this comment.
I don't think this needs to be only for Windows?
Keats
approved these changes
Oct 5, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I'm a beginner in Rust. I followed this example on the documentation page. However, there is an issue on Windows where get_url resolves colocated asset paths (page\section\asset.jpg) to something like this 'http://localhost/page\section\asset.jpg'. This is my attempt at a fix/workaround.
Sanity check:
Code changes
(Delete or ignore this section for documentation changes)
nextbranch?If the change is a new feature or adding to/changing an existing one: