Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'header' ingredient to JWT Sign operation #1957

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

RandomByte
Copy link
Contributor

Expose the 'header' option of the jsonwebtoken module as an ingredient. This allows for adding and overwriting JWT header fields such as type or kid.

header-ingredient

Not sure how you typically handle JSON input like this. Should it be sanitized before passing it into the jwt library?

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2025

CLA assistant check
All committers have signed the CLA.

Expose the 'header' option of the jsonwebtoken module [1] as an ingredient.
This allows for adding and overwriting JWT header fields such as 'type' or 'kid'.

[1]: https://github.com/auth0/node-jsonwebtoken?tab=readme-ov-file#usage
@RandomByte RandomByte force-pushed the jwt-sign/add-header-option branch from c30c5bd to 71c8c8a Compare January 4, 2025 17:31
@a3957273
Copy link
Member

Looks good to me, thanks for the contribution @RandomByte!

@a3957273 a3957273 merged commit e9b8163 into gchq:master Feb 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants