Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consumer: add Shard.PrimaryLoop() client.OpFuture #339

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

jgraettinger
Copy link
Contributor

@jgraettinger jgraettinger commented Jun 13, 2023

Expose the status of the shard's primary processing loop to those who might care.

This allows applications to reliably detect when a shard has failed, and is a more reliable mechanism than the BeginFinisher interface because that interface is only called in the context of a current consumer transaction.


This change is Reviewable

Expose the status of the shard's primary processing loop to those who
might care.

This allows applications to reliably detect when a shard has failed,
and is a more reliable mechanism than the BeginFinisher interface because
that interface is only called in the context of a current consumer
transaction.
Copy link
Contributor

@williamhbaker williamhbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgraettinger jgraettinger merged commit 3826e46 into master Jun 13, 2023
@jgraettinger jgraettinger deleted the johnny/primary-loop-future branch June 13, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants