-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI and RuboCop linter #7
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
version: 2.1 | ||
|
||
orbs: | ||
ruby: g2crowd/[email protected] | ||
|
||
workflows: | ||
version: 2 | ||
build: | ||
jobs: | ||
- ruby/build: | ||
context: g2crowd-global | ||
ruby: '2.6.6' | ||
redis: '2.8' | ||
postgres: '12.2' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,5 +6,4 @@ plugins: | |
fixme: | ||
enabled: true | ||
rubocop: | ||
enabled: true | ||
channel: rubocop-0-80 | ||
enabled: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
check_name: 'RuboCop' | ||
|
||
# Instead of installing gems from rubygems, we can run `bundle install` on your project, | ||
# you would need to do this if you are using something like 'rubocop-github' or if you don't | ||
# want to list out dependencies with the `versions` key. | ||
# Valid options: true || false | ||
# Default: false | ||
bundle: true | ||
|
||
gemfile: .overcommit_gems.rb | ||
|
||
# The scope of code that Rubocop should lint. Use this if you only want to lint changed files. If this is not set | ||
# or not equal to 'modified', Rubocop is run against the entire codebase. Note that this will not work on the master branch. | ||
# Valid options: 'modified' | ||
# Default: nil | ||
check_scope: 'modified' | ||
|
||
rubocop_force_exclusion: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
name: Linters | ||
|
||
on: | ||
push: | ||
branches-ignore: | ||
- master | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v1 | ||
|
||
- name: Rubocop Linter | ||
uses: g2crowd/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
# Use this file to configure the Overcommit hooks you wish to use. This will | ||
# extend the default configuration defined in: | ||
# https://github.com/brigade/overcommit/blob/master/config/default.yml | ||
# | ||
# At the topmost level of this YAML file is a key representing type of hook | ||
# being run (e.g. pre-commit, commit-msg, etc.). Within each type you can | ||
# customize each hook, such as whether to only run it on certain files (via | ||
# `include`), whether to only display output if it fails (via `quiet`), etc. | ||
# | ||
# For a complete list of hooks, see: | ||
# https://github.com/brigade/overcommit/tree/master/lib/overcommit/hook | ||
# | ||
# For a complete list of options that you can use to customize hooks, see: | ||
# https://github.com/brigade/overcommit#configuration | ||
# | ||
# Uncomment the following lines to make the configuration take effect. | ||
|
||
gemfile: '.overcommit_gems.rb' | ||
verify_signatures: false | ||
|
||
CommitMsg: | ||
TrailingPeriod: | ||
enabled: false | ||
SingleLineSubject: | ||
enabled: true | ||
TextWidth: | ||
enabled: true | ||
max_subject_width: 70 | ||
max_body_width: 70 | ||
|
||
PrePush: | ||
ProtectedBranches: | ||
enabled: true | ||
branches: | ||
- master | ||
|
||
PreCommit: | ||
RuboCop: | ||
enabled: true | ||
on_warn: fail # Treat all warnings as failures | ||
|
||
TrailingWhitespace: | ||
enabled: true | ||
|
||
HardTabs: | ||
enabled: true | ||
|
||
FixMe: | ||
enabled: true | ||
on_warn: fail | ||
keywords: ['FIXME', 'TODO'] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. TODO found |
||
exclude: | ||
- '.overcommit.yml' | ||
|
||
ForbiddenBranches: | ||
enabled: true | ||
branch_patterns: | ||
- master |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
source 'https://rubygems.org' | ||
ruby '2.6.6' | ||
|
||
gem 'overcommit' | ||
gem 'rubocop-g2' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
GEM | ||
remote: https://rubygems.org/ | ||
specs: | ||
activesupport (6.0.3) | ||
concurrent-ruby (~> 1.0, >= 1.0.2) | ||
i18n (>= 0.7, < 2) | ||
minitest (~> 5.1) | ||
tzinfo (~> 1.1) | ||
zeitwerk (~> 2.2, >= 2.2.2) | ||
ast (2.4.0) | ||
childprocess (3.0.0) | ||
concurrent-ruby (1.1.6) | ||
i18n (1.8.2) | ||
concurrent-ruby (~> 1.0) | ||
iniparse (1.5.0) | ||
jaro_winkler (1.5.4) | ||
minitest (5.14.0) | ||
overcommit (0.52.1) | ||
childprocess (>= 0.6.3, < 4) | ||
iniparse (~> 1.4) | ||
parallel (1.19.1) | ||
parser (2.7.1.2) | ||
ast (~> 2.4.0) | ||
rack (2.2.2) | ||
rainbow (3.0.0) | ||
rexml (3.2.4) | ||
rubocop (0.82.0) | ||
jaro_winkler (~> 1.5.1) | ||
parallel (~> 1.10) | ||
parser (>= 2.7.0.1) | ||
rainbow (>= 2.2.2, < 4.0) | ||
rexml | ||
ruby-progressbar (~> 1.7) | ||
unicode-display_width (>= 1.4.0, < 2.0) | ||
rubocop-g2 (1.1.0) | ||
rubocop (= 0.82.0) | ||
rubocop-rails (= 2.5.2) | ||
rubocop-rspec (= 1.39.0) | ||
rubocop-rails (2.5.2) | ||
activesupport | ||
rack (>= 1.1) | ||
rubocop (>= 0.72.0) | ||
rubocop-rspec (1.39.0) | ||
rubocop (>= 0.68.1) | ||
ruby-progressbar (1.10.1) | ||
thread_safe (0.3.6) | ||
tzinfo (1.2.7) | ||
thread_safe (~> 0.1) | ||
unicode-display_width (1.7.0) | ||
zeitwerk (2.3.0) | ||
|
||
PLATFORMS | ||
ruby | ||
|
||
DEPENDENCIES | ||
overcommit | ||
rubocop-g2 | ||
|
||
RUBY VERSION | ||
ruby 2.6.6p146 | ||
|
||
BUNDLED WITH | ||
1.17.3 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,10 @@ | ||
inherit_gem: | ||
rubocop-g2: | ||
- config/ruby/default.yml | ||
|
||
AllCops: | ||
Exclude: | ||
- spec/dummy/**/* | ||
|
||
Layout/LineLength: | ||
Max: 120 | ||
|
||
Layout/MultilineMethodCallIndentation: | ||
EnforcedStyle: indented_relative_to_receiver | ||
|
||
Lint/RaiseException: | ||
Enabled: true | ||
|
||
Lint/StructNewOverride: | ||
Enabled: true | ||
|
||
Style/Documentation: | ||
Enabled: false | ||
|
||
Style/HashEachMethods: | ||
Enabled: true | ||
|
||
Style/HashTransformKeys: | ||
Enabled: true | ||
|
||
Style/HashTransformValues: | ||
Enabled: true | ||
|
||
Style/NumericLiterals: | ||
Enabled: false | ||
|
||
Style/PercentLiteralDelimiters: | ||
PreferredDelimiters: | ||
default: () | ||
'%w': '()' | ||
'%W': '()' | ||
'%i': '()' | ||
'%I': '()' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.6.5 | ||
2.6.6 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FIXME found