Remove host network #205
Merged
Remove host network #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add documentation to custom-resource-definition.md and move pode affinity generation into own function. Update associated python sdk and add test. I am too afraid to run this with hostNetwork on my local machine. Signed-off-by: vsoch <[email protected]>
…inity add to 100 Signed-off-by: vsoch <[email protected]>
minimalService should likely reduce the load - I do not think hostNetwork will work here. Signed-off-by: vsoch <[email protected]>
|
@aojea I'm merging here since the current implementation with affinity seems to have a breaking change. We can follow up again on the hostNetwork idea and see if there are feet there when you are back. Have a good weekend! |
|
sure, my bad, sorry, I didn't expect we have to set weight 😄 |
No no, totally OK, and not your fault! I don't know why the tests for the previous PR missed that! I am so appreciating your contributions and these tiny things are trivial compared to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #204 (with nice changes) but removing hostNetwork, in case we want it.