Try to find a valid URL when an app shares title+URL stuffed together #1830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@allcontributors please add @andybalaam for code and bug reports |
|
I've put up a pull request to add @andybalaam! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1826 .
Look for a URL at the end of a long string of title+URL passed to us from
SendIntent. It's possible a better fix might be available by modifyingSendIntent(or even by asking for a fix to the Amazon Shopping app?) but this makes things work as they should, and doesn't do anything if we are given a valid URL, so hopefully can't do much harm even if this is later fixed upstream.Before:
After: