Check that a URL is valid as soon as we load the Add Bookmark dialog #1828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andybalaam
force-pushed
the
check-shared-url-immediately
branch
from
810a025 to
636fbde
Compare
marcelklehr
reviewed
Jan 14, 2025
marcelklehr
requested changes
Jan 14, 2025
andybalaam
changed the title
andybalaam
force-pushed
the
check-shared-url-immediately
branch
from
636fbde to
3899847
Compare
|
Thank you for stepping up to fix these! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of addressing #1826 - make sure that we display an error message in the Add Bookmark dialog immediately, if the shared URL is bad.
Before this change, there would be no error message in the "Add Bookmark" screen until we edited the URL, but now the error appears immediately:
I have zero Vue experience, so please let me know if I did it wrong.