Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock: reduce number rows deleted at per iter, add retry #27027

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dantecatalfamo
Copy link
Member

@dantecatalfamo dantecatalfamo commented Mar 11, 2025

#27002

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it)
    • Make sure cron completes successfully with thousands of unsaved expired queries
  • Manual QA for all new/changed functionality

@dantecatalfamo dantecatalfamo changed the title Reduce the number of queries deleted at a time, add retry Fix deadlock: reduce the rows deleted at a time, add retry Mar 11, 2025
@dantecatalfamo dantecatalfamo changed the title Fix deadlock: reduce the rows deleted at a time, add retry Fix deadlock: reduce number rows deleted at a time, add retry Mar 11, 2025
@dantecatalfamo dantecatalfamo changed the title Fix deadlock: reduce number rows deleted at a time, add retry Fix deadlock: reduce number rows deleted at per iter, add retry Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.98%. Comparing base (6bbf645) to head (5ab2cd2).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27027      +/-   ##
==========================================
- Coverage   63.99%   63.98%   -0.01%     
==========================================
  Files        1704     1705       +1     
  Lines      162237   162796     +559     
  Branches     4327     4327              
==========================================
+ Hits       103822   104164     +342     
- Misses      50346    50518     +172     
- Partials     8069     8114      +45     
Flag Coverage Δ
backend 64.74% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dantecatalfamo dantecatalfamo marked this pull request as ready for review March 11, 2025 18:29
@dantecatalfamo dantecatalfamo requested a review from a team as a code owner March 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants